CharonPirates.xml contains malformed XML

[Shivan Hunter]

not really a bug per se, but I'm trying to parse the source XML for reasons, and line 1678 of CharonPirates.xml is

Code: Select all

<!-- GLOBALS ------------------------------------------------------------------>

but a proper XML comment does not contain multiple hyphens except the "--" at the beginning and end. Presumably Transcendence's parser strips it out in preprocessing or handles it, but Java's XML parser (javax.xml.parsers.DocumentBuilder) fails on this line.

Not really an issue, I can get rid of it with a regex (in fact, my parser might as well discard anything matching "(?s)<!--.*?-->"). Just a heads up about an issue I ran into.

[EDIT]: aaaaaa bad tag names D:

Line 681 in MiscItems is a tag that throws an error because it doesn't start with a letter. I... may be able to deal with this using regex as well but blargh

[EDIT2]: looks like that's it! The only bad tag is "00182001_Donation" which I just internally replace all occurrences of with "a00182001_Donation" (but I won't be using it anyway).

[Atarlost]

All Transcendence XML is malformed because it references entity definitions in other files.

[Jeoshua]

Transcendence XML is not intended for the web, therefore is not subject to W3C conventions.

[Shivan Hunter]

I know, and I by no means expect George to write his XML to any standard other than what Trans's own parser expects. Since I was parsing XML for my mod anyway, I thought I'd mention the minor issues I ran into since they're easily corrected.

About entities: there are several ways to get parsers to ignore entities. I just didn't bother with them and (again) used regexes to replace them with placeholders. I also didn't mention it because it's so integral to how the XML works it's obviously not going to change (and shouldn't).