Cannot install/remove devices in Point Juno and CSC's

Bug reports for the stable versions go here.
Post Reply
Ferdinand
Militia Lieutenant
Militia Lieutenant
Posts: 123
Joined: Mon Feb 23, 2015 2:35 pm
Location: Dancing in the universe
Contact:

Tue Feb 24, 2015 9:21 am

Not sure if this is a bug, though it might be related to the refuel bug with CSC's.

I'm currently piloting an Osaka on my way to the core. Made it all the way to Heretic. But the fleet is not very coöperative. I can dock with CSC and Point Juno. Get missions from them and thats it. Armor repair or replacement is impossible (they say it's too advanced, but could repair it before I achieved rank). Miscellaneous devices cannot be removed or installed, only disabled. Same as with the refuel bug, this only happens when achieving fleet rank.

I'm playing transcendence on Wine (linux) but don't think that is very relevant for this issue.

Another issue that might be related to playing on Wine is the text on dockscreens, it gets truncated at the end of each line.
Yet another possibly Wine related issue is not playing the ingame musical score. There are some lines about this in the debuglog but don't have that available on the pc I'm working with right now.

Anyone else having the same issues?

If any of these are relevant then I'll post them on the Ministry.

User avatar
RPC
Fleet Admiral
Fleet Admiral
Posts: 2876
Joined: Thu Feb 03, 2011 5:21 am
Location: Hmm... I'm confused. Anybody have a starmap to the Core?

Tue Feb 24, 2015 11:22 am

I haven't heard of these issues before. Can you post them on the ministry with your savefile and your mods (if you have any)?
Tutorial List on the Wiki and Installing Mods
Get on Discord for mod help and general chat
Image
Image
Der Tod ist der zeitlose Frieden und das leben ist der Krieg
Wir müssen wissen — wir werden wissen!
I don't want any sort of copyright on my Transcendence mods. Feel free to take/modify whatever you want.

Ferdinand
Militia Lieutenant
Militia Lieutenant
Posts: 123
Joined: Mon Feb 23, 2015 2:35 pm
Location: Dancing in the universe
Contact:

Tue Feb 24, 2015 12:42 pm

I'll post on the Ministry as soon as possible, expect to see them there sometime tomorrrow.

User avatar
JohnBWatson
Fleet Officer
Fleet Officer
Posts: 1368
Joined: Tue Aug 19, 2014 10:17 pm

Tue Feb 24, 2015 5:14 pm

RPC wrote:I haven't heard of these issues before. Can you post them on the ministry with your savefile and your mods (if you have any)?
I've had those issues before, and posted a bug report on them. Haven't seen whether it happens with installing items, but I wouldn't be surprised.

Ferdinand
Militia Lieutenant
Militia Lieutenant
Posts: 123
Joined: Mon Feb 23, 2015 2:35 pm
Location: Dancing in the universe
Contact:

Tue Feb 24, 2015 5:21 pm

Reported bug at the ministry and attached savegame with it.
As bonus the dockscreens from Point Juno to show what is (not) happening.

josh19967
Militia Lieutenant
Militia Lieutenant
Posts: 162
Joined: Mon Aug 30, 2010 10:52 pm
Location: Vacationing at ModWorld... :D

Mon Mar 02, 2015 8:12 pm

I believe I have tracked down the problem.


In CTradingDesc.cpp (line 217) (In Trans source):

Code: Select all

	
//	Let global types adjust the price

	int iPlayerPriceAdj;
	if (bPlayerAdj 
			&& g_pUniverse->GetDesignCollection().FireGetGlobalPlayerPriceAdj(Commodity.iService, pObj, Item, NULL, &iPlayerPriceAdj))
		{
		if (iPlayerPriceAdj <= 0)
			return -1;

		iPrice = iPlayerPriceAdj * iPrice / 100;
		}
Should be:

Code: Select all

	//	Let global types adjust the price

	int iPlayerPriceAdj;
	if (bPlayerAdj 
			&& g_pUniverse->GetDesignCollection().FireGetGlobalPlayerPriceAdj(Commodity.iService, pObj, Item, NULL, &iPlayerPriceAdj))
		{
		if (iPlayerPriceAdj < 0)
			return -1;

		iPrice = iPlayerPriceAdj * iPrice / 100;
		}
Seemed to work for me.
Attachments
CTradingDesc.cpp
(22.86 KiB) Downloaded 42 times
I really don't care if I get my hair cut... *snip* NOOOOOOOOOOOO!!!!!!!!!!!

User avatar
JohnBWatson
Fleet Officer
Fleet Officer
Posts: 1368
Joined: Tue Aug 19, 2014 10:17 pm

Tue Mar 03, 2015 12:37 am

Brilliant, josh!

I'm pasting your solution to the relevant ministry post as we speak, hopefully this will be fixed in no time.

Post Reply