[Closed] Double Double!

These are old bug reports that have been closed.
Locked
Azmond
Anarchist
Anarchist
Posts: 8
Joined: Wed Dec 08, 2010 8:56 pm
Location: Traveling the stars in a Ronin ship drinking Red Nubla!

in the statistics i've noticed that there's double the stats for profits. This might be the first report of it or not but in anycase thought you guys'd like to know... ... >> if i posted something that was allready known my bad. :mrgreen:
Time to get up n' go-go-GO!
Drako Slyith
Fleet Officer
Fleet Officer
Posts: 1036
Joined: Wed Feb 03, 2010 4:28 am
Location: Researching how to make St. Kats star go supernova.
Contact:

I've also noticed that I get triple stats for almost everything, like
Never reached Rigel Aurelias
Never reached Rigel Aurelias
Never reached Rigel Aurelias
Never reached Charon
Never reached Charon
Never reached Charon
Never reached St. Katharines
Never reached St. Katharines...
It does the same for regrets and accomplishments.
Image
Image
Play in over 100 systems in a network. Play the 2011 Mod Of the Year
and the highest rated mod on Xelerus, The Network.
Play the July Mod of the Month, Fellow Pilgrims!
Play My other mods as well
(Drako Slyith)* I am a person
(Eliza chatbot)> Do you believe it is normal to be a person?
Amilir
Militia Lieutenant
Militia Lieutenant
Posts: 151
Joined: Fri Feb 12, 2010 4:56 pm
Location: With the stRong.

All adventure extensions with the standard GetGlobalAchivements in them provide a duplicate for some reason. I haven't messed with it much.
User avatar
Aury
Fleet Admiral
Fleet Admiral
Posts: 5421
Joined: Tue Feb 05, 2008 1:10 am
Location: Somewhere in the Frontier on a Hycrotan station, working on new ships.

I think this only ever happens with mods; I've never seen it occur in a vanilla game.
(shpOrder gPlayership 'barrelRoll)
(plySetGenome gPlayer (list 'Varalyn 'nonBinary))
Homelab Servers: Xeon Silver 4110, 16GB | Via Quadcore C4650, 16GB | Athlon 200GE, 8GB | i7 7800X, 32GB | Threadripper 1950X, 32GB | Atom x5 8350, 4GB | Opteron 8174, 16GB | Xeon E5 2620 v3, 8GB | 2x Xeon Silver 4116, 96GB, 2x 1080ti | i7 8700, 32GB, 6500XT
Workstations & Render machines: Threadripper 3990X, 128GB, 6900XT | Threadripper 2990WX, 32GB, 1080ti | Xeon Platinum 8173M, 48GB, 1070ti | R9 3900X, 16GB, Vega64 | 2x E5 2430L v2, 24GB, 970 | R7 3700X, 32GB, A6000
Gaming Systems: R9 5950X, 32GB, 6700XT
Office Systems: Xeon 5318Y, 256GB, A4000
Misc Systems: R5 3500U, 20GB | R5 2400G, 16GB | i5 7640X, 16GB, Vega56 | E5 2620, 8GB, R5 260 | P4 1.8ghz, 0.75GB, Voodoo 5 5500 | Athlon 64 x2 4400+, 1.5GB, FX 5800 Ultra | Pentium D 3.2ghz, 4GB, 7600gt | Celeron g460, 8GB, 730gt | 2x Athlon FX 74, 8GB, 8800gts 512 | FX 9590, 16GB, R9 295x2 | E350, 8GB | Phenom X4 2.6ghz, 16GB, 8800gt | random core2 duo/atom/i5/i7 laptops
User avatar
alterecco
Fleet Officer
Fleet Officer
Posts: 1658
Joined: Wed Jan 14, 2009 3:08 am
Location: Previously enslaved by the Iocrym

Sounds like a genuine bug in the GetGlobalAcheivements code... Probably the engine is seeing both the vanilla and the ones exclusive to the mod. Is this while playing vanilla, or a mod like The Network or similar?
Amilir
Militia Lieutenant
Militia Lieutenant
Posts: 151
Joined: Fri Feb 12, 2010 4:56 pm
Location: With the stRong.

It doesn't happen without mods installed, but adventure extensions doing this is a bug in itself. One adv ext's stuff should NOT affect another adv ext. If I had to guess, the <OnGameStart> and <OnGameEnd> events are only called if you're using that specific adv, but the <GetGlobalAchievements> event is always called. While adv exts could avoid the duplicate bug, there is no way I know of to overwrite vanilla achievements. You can only add achievements. That is the real bug. That should be easy enough to fix though.

To be clear, you see the bug while playing ANY adv ext, including normal transcendence, if you have another adv ext with
<GetGlobalAchievements>(intGetGlobalAchievements)</GetGlobalAchievements> in your extensions folder. 'Vanilla' is a little unclear in this context.
User avatar
alterecco
Fleet Officer
Fleet Officer
Posts: 1658
Joined: Wed Jan 14, 2009 3:08 am
Location: Previously enslaved by the Iocrym

Vanilla is the unmodded game... if it is a copy of vanilla (eg. the one with the starmap), then it is not vanilla.

But yes, it is definitely a bug. Does anyone feel like filing it?
george moromisato
Developer
Developer
Posts: 2997
Joined: Thu Jul 24, 2003 9:53 pm
Contact:

alterecco wrote:Vanilla is the unmodded game... if it is a copy of vanilla (eg. the one with the starmap), then it is not vanilla.

But yes, it is definitely a bug. Does anyone feel like filing it?
Definitely a bug, thanks! I've fixed it for 1.06, so no need to file it.
Locked