items questions on fire event and eq

[Betelgeuse]

I have some questions.

When you fire an item event with objFireItemEvent does gItem and gSource get set and reset when it gets returned or is it up to the caller to do those things?

Given two devices of the same type and data installed on a single ship would they evaluate eq to True?
Given two armors of the same type and data installed on a single ship would they evaluate eq to True?

bonus question: In onUninstall is gItem installed. (assuming gItem is the item being uninstalled)

[george moromisato]

I have some questions.

When you fire an item event with objFireItemEvent does gItem and gSource get set and reset when it gets returned or is it up to the caller to do those things?

gItem and gSource are set and reset.

Given two devices of the same type and data installed on a single ship would they evaluate eq to True?
Given two armors of the same type and data installed on a single ship would they evaluate eq to True?

No, in both cases. The installation location will be different for each item (a different device slot or a different armor segment location).

bonus question: In onUninstall is gItem installed. (assuming gItem is the item being uninstalled)

There may be a bug here.

For devices, it is called BEFORE the item is uninstalled. But for armor, it is called just AFTER.

I think for armor I will move the call to before the item is uninstalled.

Note that in either case, the item is in a transition state. The original goal of the OnUninstall event is to give you a hook to undo things that the item did on install (such as add an overlay to the ship). If you try to manipulate the item itself, there probably are bugs and unintended consequences.

Also, in the future I will provide a way to prevent an item from being uninstalled.

[Aeonic]

Also, in the future I will provide a way to prevent an item from being uninstalled.

Sweet. I've always wanted some evil Advanced Sentient Patch Spiders that cling to your ship and eat your hull until you manage to get them blasted off.

[Betelgeuse]

thanks, in onUnInstall I want to do stuff based on installed items, but now that I know that eq evaluates to nil even in cases where everything other than location is the same makes it possible to filter out the current item (because it isn't going to be installed after the event occurs)

[george moromisato]

thanks, in onUnInstall I want to do stuff based on installed items, but now that I know that eq evaluates to nil even in cases where everything other than location is the same makes it possible to filter out the current item (because it isn't going to be installed after the event occurs)

Cool, you can rely on that.

One bug that I found: Currently, you shouldn't manipulate any items in the OnUninstall call--for example, adding items to the ship in the middle of OnUninstall will either crash or corrupt memory. I'll fix that in RC3 [But even then, you probably shouldn't manipulate the item being uninstalled.]

[Betelgeuse]

is gItem installed or not consistently with armors and devices? Also does the onUnInstall bug effect uninstalling in onUnInstall and installing devices in onInstall? (I was going to use virtual 0 slot devices)

[Aury]

what if an item is forcefully deleted? will uninstall still trigger if it is installed?

[george moromisato]

is gItem installed or not consistently with armors and devices? Also does the onUnInstall bug effect uninstalling in onUnInstall and installing devices in onInstall? (I was going to use virtual 0 slot devices)

In RC3, it is consistent between armors and devices. In RC2 it is not.

I think, as long as the item existed on the ship prior to OnUninstall/OnInstall, then I think you're OK--but I'm not sure. Either way, it is fixed in RC3.

(And you'll be able to add virtual items and install/uninstall in OnInstall/OnUninstall--at least I hope so: it's a bug if not.)

BTW, also in RC3 is a way to enumerate virtual items.

Thanks, as always, for pushing the limits!

[george moromisato]

what if an item is forcefully deleted? will uninstall still trigger if it is installed?

No, you will get an error message if you try.

[Aury]

ok, so it's a non-issue, right?

[Betelgeuse]

is gItem installed or not consistently with armors and devices? Also does the onUnInstall bug effect uninstalling in onUnInstall and installing devices in onInstall? (I was going to use virtual 0 slot devices)

In RC3, it is consistent between armors and devices. In RC2 it is not.

oh sorry I meant to say in onInstall is gItem installed or not ...
enumerating virtual items is going to be helpful 8)

edit: is there a way of using a UNID in objGetItems?

edit2: nvm I just saw it is on a ticket for 1.1

[george moromisato]

oh sorry I meant to say in onInstall is gItem installed or not ...
enumerating virtual items is going to be helpful 8)

edit: is there a way of using a UNID in objGetItems?

edit2: nvm I just saw it is on a ticket for 1.1

In OnInstall, gItem is installed for both armor and devices.

[Betelgeuse]

(And you'll be able to add virtual items and install/uninstall in OnInstall/OnUninstall--at least I hope so: it's a bug if not.)

http://wiki.neurohack.com/transcendence/trac/ticket/220

I am not using virtual items currently but will use them in RC3 (if that bug is fixed of course)