Star Weaver's crash report

[george moromisato]

At IRC day, Star Weaver (I think) sent me a pastebin showing a crash when removing items. Here's what I found:

1. There is a slight typo in the mod:

Code: Select all

(objEnumItems wvrGlobalShip "*wI" weap (shpRemoveDevice wvrGlobalShip weap))

The criteria "*wI" matches all installed item (The * means all items types. The w is ignored, since the * already implies that you're looking for weapons). The result is that the code above tries to uninstall all items, including items that are not installed. The mod will not crash if you change the criteria to "wI"

2. There is a subtle bug in the engine: When you install/uninstall devices on an AI ship, the AI does not realize that the devices have changed, so it doesn't use weapons properly (i.e., it may use a weapon thinking that it has a long range when in fact that weapon was uninstalled). I've fixed this bug in 1.07.

3. Because of #1, the ship's shield generator is uninstalled. Because of #2, the AI doesn't realize that the shield generator has been uninstalled and it tries to use it. Since it can't find the device, the game crashes. I've also fixed this in 1.07.

Thanks for the report--it helped me to find some good bugs.

[PM]

Nice! That explains why the game crashes when AI controlled ships in Playership Drones remove and install patch spiders by themselves.

[alterecco]

3. Because of #1, the ship's shield generator is uninstalled. Because of #2, the AI doesn't realize that the shield generator has been uninstalled and it tries to use it. Since it can't find the device, the game crashes. I've also fixed this in 1.07.

Cool! That will fix some nasty bugs in WE and G.O.D. as well. Thanks!